Skip to content

fix(noderesource): raise cosmos-exporter memory ceiling 384Mi -> 512Mi (stopgap) #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdchatham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(noderesource): raise cosmos-exporter memory ceiling 384Mi -> 512Mi (stopgap) #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/noderesource/noderesource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,11 @@ func defaultCosmosExporterResources() corev1.ResourceRequirements {
corev1.ResourceMemory: resource.MustParse("64Mi"),
},
Limits: corev1.ResourceList{
corev1.ResourceMemory: resource.MustParse("384Mi"),
// Temporary: raises the OOM ceiling to reduce restart frequency
// while a suspected leak in sei-cosmos-exporter (goroutine-per-
// event fan-out in HandleBankTransferEvent, not the eventstream
// reconnect path) gets fixed upstream. Does not fix the leak.
corev1.ResourceMemory: resource.MustParse("512Mi"),
},
}
}
Expand Down
4 changes: 2 additions & 2 deletions internal/noderesource/noderesource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,14 +1771,14 @@ func TestCosmosExporter_DefaultResources(t *testing.T) {
sts := mustGenerateStatefulSet(t, node, platformtest.Config())
ce := findContainer(sts.Spec.Template.Spec.Containers, containerNameCosmosExporter)

// 50m/64Mi requests, 256Mi memory limit, no CPU limit (see
// 50m/64Mi requests, 512Mi memory limit, no CPU limit (see
// defaultCosmosExporterResources — scrape pulls would throttle).
cpuReq := ce.Resources.Requests[corev1.ResourceCPU]
memReq := ce.Resources.Requests[corev1.ResourceMemory]
memLim := ce.Resources.Limits[corev1.ResourceMemory]
g.Expect(cpuReq.String()).To(Equal("50m"))
g.Expect(memReq.String()).To(Equal("64Mi"))
g.Expect(memLim.String()).To(Equal("384Mi"))
g.Expect(memLim.String()).To(Equal("512Mi"))
_, hasCPULimit := ce.Resources.Limits[corev1.ResourceCPU]
g.Expect(hasCPULimit).To(BeFalse())
}
Expand Down
Loading