Restore DualWrite import duplication and change pointer schema#3271
Open
Restore DualWrite import duplication and change pointer schema#3271
Conversation
composite.Iterator/ReverseIterator now mirror Get/Has routing (ReadMode != CosmosOnlyRead) instead of gating on WriteMode == SplitWrite, so iteration and point reads stay consistent across all WriteMode/ReadMode combinations. EVMStateStore.Iterator/ReverseIterator now reuse routeKey to pick the correct sub-DB in SeparateEVMSubDBs mode, since every real caller iterates within a single bucket (e.g. pointer registry stays in Legacy). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Two changes that together eliminate the need for SS-path iteration on EVM data: 1. composite.Import now sends evm snapshot nodes to BOTH cosmos and evm under DualWrite (previously mutually-exclusive after #3250). This restores the state-sync-time safety net that made mainnet DualWrite state-synced nodes surface pointer lookups via cosmos even while the iterator routing bug was present. 2. Pointer registry collapsed to single-key: one record per pointee, with the uint16 version packed into the value instead of the key suffix. GetPointerInfo/GetAnyPointerInfo become single Gets — the only hot-path EVM iterator is gone. Migration handlers updated to read the version-prefixed value and drop the now-unneeded dedup map. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Kbhat1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.