Chore: weekly repo cleanup#497
Merged
Merged
Conversation
- fixed linter outputs - fixed spellchecker outputs - synced badges - synced tags - synced indexes
- fixed mdxTextExpression build warnings - fixed broken SEAL CoC link - fixed mermaid dark mode visibility - simplified post-build scripts console logs - added guidance for too long files to contribution docs - cleaned up numbered heading in awareness fw - fixed linter outputs - fixed spellchecker outputs - synced badges - synced tags - synced indexes
frameworks-volunteer
approved these changes
May 25, 2026
Collaborator
frameworks-volunteer
left a comment
There was a problem hiding this comment.
Model: z-ai/glm-5.1 Reasoning: medium Provider: openrouter
Reviewed PR #497 (Chore: weekly repo cleanup). 26 files changed vs develop.
Security Review -- PASS
- No hardcoded secrets, tokens, or API keys
- innerHTML usage in MermaidRenderer is pre-existing (mermaid SVG + error message interpolation); no new vectors introduced
- MutationObserver re-renders on theme toggle only; same code prop, no injection risk
- No suspicious dependencies, no eval, no unsafe deserialization
QA Review -- PASS (minor notes)
- CoC link updated to
https://radar.securityalliance.org/code_of_conduct/-- verified 200 OK - Awareness pages: numbered headings (1., 2.1., 3.4.1.) stripped to plain headings -- cleaner, correct
- Cert pages: revision line moved after intro paragraph -- consistent reorder, no content change
- MermaidRenderer: dark mode via
document.documentElement.classList.contains("dark")+ MutationObserver; unique render ID viarenderCount.currentprevents ID collisions -- good pattern - Generator scripts: verbose per-file console.logs removed, summary only -- cleaner build output
- network-security.mdx: line-length formatting only (no content changes), markdown table alignment
- contributors.json: badge sync (active/dormant updates), new
tansawitentry -- correct structure - wordlist.txt: HSTS added -- appropriate given network-security references
- Template:
<framework-folder>->{framework-folder}-- clearer placeholder syntax - VPNs casing fix:
Vpns->VPNswith ACRONYM_MAP in generator -- good fix
Minor note: commits fe42015 and af70135 add then remove target="_blank" on CoC link -- revert-in-place. Not harmful but slightly messy history. Consider squashing before merge if desired.
Verdict: Approve -- all changes are routine cleanup, linter/spellcheck sync, and incremental improvements. No security or quality concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In thi PR:
Frameworks PR Checklist
Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:
vocs.config.tsadding thedev: trueparameter