Repository navigation
OPS-10: no tag for a moved, already-published package - #202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPS-10: a moved package that is already on npm is no longer tagged.
The problem
scripts/release-check.mjssetstag(which runs release.yml's "Tag and GitHub Release" step) whenever the version differs fromHEAD~1. When a package moves, for example from the repository root topackages/<name>as the react-data-import and react-xlsx-viewer scaffolds do,HEAD~1has no package.json at the new path. The previous version is thennull, sotagwas true. Nothing was published, because 0.0.1 is already on npm, but merging would have created av0.0.1tag and GitHub Release on the scaffold commit.The change
A package.json that is new at its path and whose version is already on npm is a moved package, not a release, so it gets no tag. The verdict line says so:
… is already on npm (package.json is new at this path: moved, not released; no tag). Everything else is unchanged:workflow_dispatch)release-check.test.mjs, one per row above. All 40 tests pass.release-check.mjsandrelease-check.test.mjsare identical in javascript-excel, react-data-export, react-data-import and react-xlsx-viewer: sha12d5e497ebeaf…and3a6e4d3e6f9a…, one PR per repository.Checked on the react-xlsx-viewer scaffold (XLV-1,
packages/react-xlsx-viewer, HEAD~1 = main)tag=true.release=false,version-changed=true,tag=false.No package change and no changeset.