Draft: Add Zenoh 1.0 protocol contrib layer#5043
Open
polybassa wants to merge 4 commits into
Open
Conversation
AI-Assisted: yes (Cursor AI)
AI-Assisted: no
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5043 +/- ##
==========================================
- Coverage 80.29% 80.26% -0.03%
==========================================
Files 383 389 +6
Lines 95172 96670 +1498
==========================================
+ Hits 76415 77594 +1179
- Misses 18757 19076 +319
🚀 New features to boost your workflow:
|
polybassa
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Scapy contrib dissector for the Zenoh 1.0 wire format and a dedicated UTS test campaign to validate encoding/decoding, message dispatch, and port bindings.
Changes:
- Introduces
scapy.contrib.zenohwith custom varint/bytes/id fields, scouting + transport message layers, and basic network message dispatch. - Adds
test/contrib/zenoh.utscovering field codecs, message build/dissect roundtrips, dispatch layers, and UDP/TCP bindings on standard Zenoh ports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
scapy/contrib/zenoh.py |
New Zenoh contrib protocol layer implementation (fields, packets, dispatch, bindings). |
test/contrib/zenoh.uts |
New regression tests for Zenoh field encoding/decoding and packet parsing/binding behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+69
to
+78
| def getfield(self, pkt, s): | ||
| value = 0 | ||
| shift = 0 | ||
| for i in range(len(s)): | ||
| b = orb(s[i]) | ||
| value |= (b & 0x7F) << shift | ||
| shift += 7 | ||
| if not (b & 0x80): | ||
| return s[i + 1:], value | ||
| return b"", value |
Comment on lines
+59
to
+67
| def addfield(self, pkt, s, val): | ||
| if val is None: | ||
| val = 0 | ||
| data = bytearray() | ||
| while val > 0x7F: | ||
| data.append((val & 0x7F) | 0x80) | ||
| val >>= 7 | ||
| data.append(val & 0x7F) | ||
| return s + bytes(data) |
Comment on lines
+96
to
+101
| def addfield(self, pkt, s, val): | ||
| if val is None: | ||
| val = b"" | ||
| if isinstance(val, str): | ||
| val = val.encode() | ||
| return s + chb(len(val)) + val |
added 2 commits
July 15, 2026 07:21
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-Assisted: yes (Cursor AI)