Update collaborator filter parameter structure - #467
Merged
Conversation
seafile-dev
reviewed
Aug 13, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Comment
Warnings:
- The callback-shape fix has no regression coverage; see the inline comment.
| }; | ||
|
|
||
| onSelectCollaborator = (value) => { | ||
| onSelectCollaborator = ({ columnOption: collaborator }) => { |
There was a problem hiding this comment.
[Warning] 缺少协作人过滤回归测试
Why this matters:
本次修复依赖 CollaboratorFilter 传入 { columnOption }，此前这里把整个包装对象传给更新函数，导致 collaborator.email 为空。现有测试未覆盖普通协作人列及链接/公式引用协作人列的选择和回显，因此该契约再次变化时会静默回归。
Suggested fix: 为 FilterItem/CollaboratorFilter 添加回归测试，分别模拟两个入口选择 { columnOption: collaborator }，断言 updateFilter 收到包含该邮箱的 filter_term，并断言所选协作人会被渲染。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.