Skip to content

Issue 2919 add a manual check for referential integrity - #2946

Open
nemanja-vujic wants to merge 2 commits into
mainfrom
issue-2919-add-a-manual-check-for-referential-integrity
Open

Issue 2919 add a manual check for referential integrity#2946
nemanja-vujic wants to merge 2 commits into
mainfrom
issue-2919-add-a-manual-check-for-referential-integrity

Conversation

@nemanja-vujic

Copy link
Copy Markdown

No description provided.

@nemanja-vujic
nemanja-vujic requested a review from a team as a code owner August 14, 2026 16:28
@nemanja-vujic
nemanja-vujic requested review from amontanez24 and removed request for a team August 14, 2026 16:28
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.10145% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.06%. Comparing base (4615375) to head (c8fd6e5).

Files with missing lines Patch % Lines
sdv/evaluation/utils.py 96.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files          75       76       +1     
  Lines        8589     8651      +62     
==========================================
+ Hits         8424     8484      +60     
- Misses        165      167       +2     
Flag Coverage Δ
integration 76.51% <78.26%> (+0.01%) ⬆️
unit 97.06% <97.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdv-team

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@amontanez24
amontanez24 requested a review from frances-h August 14, 2026 18:23

@amontanez24 amontanez24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nemanja-vujic Can you add "resolves #2919" to the description of this PR. That will close the issue when the PR is merged

Comment thread sdv/evaluation/utils.py
Comment on lines +69 to +71
if table_name == relationship['child_table_name'] and child_foreign_key == list(
foreign_key_names
):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this fail if the foreign key names aren't in the same order? For example ['colA', 'colB', 'colC'] instead of ['colB', 'colC', 'colA'] ? I think those should still match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants