Make single table metrics that require metadata also accept a table name - #905
Open
fealho wants to merge 3 commits into
Open
Make single table metrics that require metadata also accept a table name#905fealho wants to merge 3 commits into
fealho wants to merge 3 commits into
Conversation
Contributor
fealho
marked this pull request as ready for review
August 12, 2026 17:04
fealho
requested review from
R-Palazzo and
sarahmish
and removed request for
a team
August 12, 2026 17:05
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 95.63% 95.65% +0.01%
==========================================
Files 122 122
Lines 5227 5267 +40
==========================================
+ Hits 4999 5038 +39
- Misses 228 229 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sarahmish
reviewed
Aug 13, 2026
| return metadata, table_name | ||
|
|
||
| tables = metadata['tables'] | ||
| _validate_metadata_dict(tables) |
Contributor
There was a problem hiding this comment.
wasn't this already validated since _validate_metadata_dict(metadata) passes at this point?
Member
Author
There was a problem hiding this comment.
_validate_metadata_dict(metadata) just confirms metadata a dict, but tables could be a list.
This case still needs to be checked: metadata = {'tables': []}
Comment on lines
+71
to
+72
| if not table_names: | ||
| raise ValueError('Metadata does not contain any tables.') |
Contributor
There was a problem hiding this comment.
would _validate_metadata_dict pass if there are no tables? If so, can you add that to the unit tests?
fealho
force-pushed
the
issue-891-table-name-parameter
branch
from
August 16, 2026 22:29
21835ca to
82480f2
Compare
fealho
force-pushed
the
issue-891-table-name-parameter
branch
from
August 16, 2026 23:02
82480f2 to
d80808c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CU-86bb1gwt1, Resolve #891