Update Core to v0.5.5 with Sequential support and Eigen 5.0.1 - #670
Open
sdatkinson wants to merge 4 commits into
Open
Update Core to v0.5.5 with Sequential support and Eigen 5.0.1#670sdatkinson wants to merge 4 commits into
sdatkinson wants to merge 4 commits into
Conversation
sdatkinson
marked this pull request as ready for review
August 9, 2026 23:16
sdatkinson
force-pushed
the
core-v0.5.5
branch
from
August 22, 2026 23:18
52900c4 to
f657ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sequentialmodel NeuralAmpModelerCore#323 (d2b2954)bc3b398), matching Core and superseding Update NeuralAmpModelerCore to 0.5.4 and Eigen to 5.0.1 #650sequential.cppandsequential.h, to the macOS, iOS, and Windows projectsmainImpact
The plugin recognizes NAM 0.7.0
Sequentialmodels and chains their child DSP models. This fixes loading the Gateway 1.1.0 WaveNet→Linear and LSTM→Linear models while retaining the v0.5.5 Core and Eigen updates.The Core submodule currently points to the tip of sdatkinson/NeuralAmpModelerCore#323, which is based directly on the current Core
maincandidate.Validation
run_tests: passeddeluxe-reverb-atmospheric.nam(WaveNet→Linear): passeddeluxe-reverb-vibrato-atmospheric.nam(LSTM→Linear): passedSequentialimplementation: verifiedgit diff --check: passedNeuralAmpModeler/projects/resample.cppreference already present onmain