Remove VST2 build targets#615
Merged
Merged
Conversation
Drop VST2 Visual Studio projects, macOS scheme and plist, and trim VST2-related scripts and shared config. Align Windows/macOS project files. Made-with: Cursor
Resolve project conflicts: take main's Windows vcxproj entries for wavenet/a2_fast. Keep macOS VST2 removed on this branch while adding a2_fast.cpp to all remaining targets in project.pbxproj. Made-with: Cursor
guitarlum
referenced
this pull request
in guitarlum/VoLum
May 11, 2026
…c04e9)
VoLum has never shipped VST2 (makedist-win.bat and makedist-mac.sh only build
APP + VST3) and Steinberg deprecated the VST2 SDK; new releases cannot ship
VST2 anymore. This commit removes the dead VST2 build infrastructure that was
inherited from the upstream fork:
- NeuralAmpModeler-vst2.vcxproj{,.filters,.user}
- macOS-VST2.xcscheme
- NeuralAmpModeler-VST2-Info.plist
- makedist-win.bat: outdated comment ("build VST2 and AAX" -> "build AAX")
Total: 5 files removed (~37KB / ~750 lines of dead project XML), no
behavioral change for any shipped target. 216 tests still pass; standalone
app builds cleanly.
DEFERRED to 1.1 (need a macOS verification pass):
- NeuralAmpModeler-macOS.xcodeproj/project.pbxproj VST2 target entries
(PBXNativeTarget, buildConfigurations, frameworks references).
- Dead VST2 branches in update_version-mac.py, postbuild-win.bat,
makedist-mac.sh, common-mac.xcconfig, common-win.props. Each is gated by
a condition that is never true now that the project files / scheme are
gone, so leaving them in place is safe but cosmetically untidy.
Partial cherry-pick of upstream NAM Player commit bfc04e9 "Remove VST2 build
targets (#615)". The other 7 outstanding upstream commits since divergence
were evaluated and intentionally not taken for 1.0 (see AGENTS.md
"Upstream Sync" for the workflow + tracking remote).
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop VST2 Visual Studio projects, macOS scheme and plist, and trim VST2-related scripts and shared config. Align Windows/macOS project files.
Made-with: Cursor
Thanks for making a Pull Request!
Please fill out this template so that you can be sure that your PR does everything it needs to be accepted.
Description
What does your PR do?
Include Closing words to link this PR to the Issue(s) that it relates to.
PR Checklist
format.bash?Unserialization.cpp.)