Fix FreeBSD major and minor macro collision - #326
Open
Helshr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304
Summary
FreeBSD defines
major(x)andminor(x)macros insys/types.h. Those macros expand the parenthesized member initializers innam::Version, causing builds that includeNAM/get_dsp.hto fail.Use braced member initialization to avoid the function-like macro expansion while preserving the existing public field names and API.
Tests
major(x)andminor(x)macros while includingNAM/get_dsp.h./build/tools/run_testspasses successfully