-
Notifications
You must be signed in to change notification settings - Fork 88
Transfo manager base #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ajkswamy
wants to merge
7
commits into
transformation_manager
Choose a base branch
from
transfo_manager_base
base: transformation_manager
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Transfo manager base #1164
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
30511a7
chore: added pandas-stubs as dev dependency; helps with type checking
ajkswamy 986f0bb
chore: added local hatch.toml to gitignore
ajkswamy 5e0d12f
chore: Add .kilo and plans to .gitignore
ajkswamy 81bb674
feat: added literals and types for element types and group names
ajkswamy 787770a
feat: added .coverage and htmlcov to gitignore
ajkswamy 9b2d259
feat: transformation manager at the root of spatialdata object
ajkswamy ca80f91
fix: io_zarr.py mixup between ELEMENT_TYPE_VECTOR/RASTER
ajkswamy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,8 @@ | |
| # _core.query.spatial_query | ||
| "bounding_box_query": "spatialdata._core.query.spatial_query", | ||
| "polygon_query": "spatialdata._core.query.spatial_query", | ||
| # _core.transformation_manager | ||
| "TransformationManager": "spatialdata._core.transformation_manager", | ||
| # _core.spatialdata | ||
| "SpatialData": "spatialdata._core.spatialdata", | ||
| # _io._utils | ||
|
|
@@ -115,6 +117,8 @@ | |
| # _core.query.spatial_query | ||
| "bounding_box_query", | ||
| "polygon_query", | ||
| # _core.transformation_manager | ||
| "TransformationManager", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, to be removed. |
||
| # _core.spatialdata | ||
| "SpatialData", | ||
| # _io._utils | ||
|
|
@@ -208,6 +212,9 @@ def __dir__() -> list[str]: | |
| # _core.spatialdata | ||
| from spatialdata._core.spatialdata import SpatialData | ||
|
|
||
| # _core.transformation_manager | ||
| from spatialdata._core.transformation_manager import TransformationManager | ||
|
Comment on lines
+215
to
+216
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
|
|
||
| # _io._utils | ||
| from spatialdata._io._utils import get_dask_backing_files | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the user to instantiate it. It can be removed.