Fix multiscale resolution selection picking wrong scale level#591
Open
Fix multiscale resolution selection picking wrong scale level#591
Conversation
The heuristic in `_multiscale_to_spatial_image` used `min()` on indices from an ascending-sorted scale list, which selected *lower* resolution when x and y optimal pixel counts disagreed. It also relied on `searchsorted` over y_dims that may not be sorted after x-based reordering. Replace with a direct loop that finds the lowest-resolution scale where both x and y dimensions meet the target pixel count, falling back to the highest available resolution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
+ Coverage 76.30% 76.32% +0.01%
==========================================
Files 11 11
Lines 3229 3227 -2
Branches 757 757
==========================================
- Hits 2464 2463 -1
Misses 465 465
+ Partials 300 299 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_multiscale_to_spatial_imageusedmin(x_index, y_index)on an ascending-sorted scale list, selecting lower resolution when x/y optimal pixel counts disagreed — opposite of the stated intentsearchsortedon y_dims that may not be sorted after x-based reordering (e.g. non-uniform downsampling across pyramid levels)