stop fetching blog index on every next config load#1587
Open
mooncitydev wants to merge 1 commit intoscroll-tech:sepoliafrom
Open
stop fetching blog index on every next config load#1587mooncitydev wants to merge 1 commit intoscroll-tech:sepoliafrom
mooncitydev wants to merge 1 commit intoscroll-tech:sepoliafrom
Conversation
Made-with: Cursor
|
@mooncitydev is attempting to deploy a commit to the Scroll Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
removed the side-effect import of \scripts/download-blog-posts.data.json.mjs\ from
ext.config.mjs.
why
that script runs \etchPosts()\ at module load (top-level \�wait), so it ran whenever Next loaded the config — including
ext dev\ and
ext build. that meant every build depended on reaching \�log.scroll.cat, added latency, and could fail in offline or locked-down CI even though the blog list is already checked in under \src/assets/blog/.
updating the list is already a separate step via \yarn fetch:bloglist\ /
pm run fetch:bloglist\ in package.json, so the config import was redundant for normal builds.
testing
not run here (local node_modules install had issues); change is a one-line removal of an import.