refactor: clean up invalid log tags (#426) - #684
Open
akkicodes-dev wants to merge 1 commit into
Open
Conversation
Member
|
@prince-0408, would you be able to take a look? Thanks so much for the PR, @akkicodes-dev! |
Collaborator
@andrewtavis Sure! on it! |
Collaborator
|
LGTM! Reviewed the changes across all 3 files:
Thanks @akkicodes-dev! |
prince-0408
approved these changes
Aug 23, 2026
Member
|
Discussing this with @angrezichatterbox right now, we're wondering what the use would be for keeping these logs at all. It might be nice to have an audit of the current logs that we have and whether they're useful for the development process :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up invalid, typo'd, and generic log tags identified as part of #426.
Changes
KeyboardBase.kt: Replaced invalid unicode symbol tag"≠"with properTAGconstant ("KeyboardBase")KeyboardView.kt: Fixed typo'd tag"Souncheck"→TAGconstant ("SoundCheck")LanguageSettingsScreen.kt: Replaced generic, clashing"Navigation"tag (used in 3 places) with specificTAGconstant ("LanguageSettingsScreen")Testing
./gradlew lintKotlin detekt— passed, no issues./gradlew test— all tests passedNote
Parts of this PR were AI-assisted (Antigravity); all changes were manually reviewed line-by-line, verified via local build/lint/test, and tested on a physical device before submission.
Part of #426.