Skip to content

refactor: clean up invalid log tags (#426) - #684

Open
akkicodes-dev wants to merge 1 commit into
scribe-org:mainfrom
akkicodes-dev:refactor/426-log-tags-cleanup
Open

refactor: clean up invalid log tags (#426)#684
akkicodes-dev wants to merge 1 commit into
scribe-org:mainfrom
akkicodes-dev:refactor/426-log-tags-cleanup

Conversation

@akkicodes-dev

Copy link
Copy Markdown

Summary

Cleans up invalid, typo'd, and generic log tags identified as part of #426.

Changes

  • KeyboardBase.kt: Replaced invalid unicode symbol tag "≠" with proper TAG constant ("KeyboardBase")
  • KeyboardView.kt: Fixed typo'd tag "Souncheck"TAG constant ("SoundCheck")
  • LanguageSettingsScreen.kt: Replaced generic, clashing "Navigation" tag (used in 3 places) with specific TAG constant ("LanguageSettingsScreen")

Testing

  • ./gradlew lintKotlin detekt — passed, no issues
  • ./gradlew test — all tests passed
  • Manually tested on a physical device: keyboard typing, sound feedback, and Language Settings navigation all work as expected with no regressions

Note

Parts of this PR were AI-assisted (Antigravity); all changes were manually reviewed line-by-line, verified via local build/lint/test, and tested on a physical device before submission.

Part of #426.

@andrewtavis

Copy link
Copy Markdown
Member

@prince-0408, would you be able to take a look? Thanks so much for the PR, @akkicodes-dev!

@prince-0408

Copy link
Copy Markdown
Collaborator

@prince-0408, would you be able to take a look? Thanks so much for the PR, @akkicodes-dev!

@andrewtavis Sure! on it!

@prince-0408

Copy link
Copy Markdown
Collaborator

LGTM!

Reviewed the changes across all 3 files:

  • Replaced invalid Unicode tag "≠" in KeyboardBase.kt with TAG = "KeyboardBase".
  • Replaced generic "Navigation" log tags in LanguageSettingsScreen.kt with TAG = "LanguageSettingsScreen".
  • Fixed typo'd "Souncheck" tag in KeyboardView.kt with a TAG constant.

Thanks @akkicodes-dev!

@andrewtavis

Copy link
Copy Markdown
Member

Discussing this with @angrezichatterbox right now, we're wondering what the use would be for keeping these logs at all. It might be nice to have an audit of the current logs that we have and whether they're useful for the development process :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants