feat(3504): Allow @ in meta key validation#92
Merged
Conversation
yk634
approved these changes
Jul 10, 2026
minghay
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
meta-clicould not handle meta keys containing@, even though stage setup/teardown-related parameters may use keys such asstage@explicit-setup-and-teardown:setupandparameters.stage@test:teardown.test.value.Because
@was rejected by the existing meta key validation, users could not access or manipulate these values throughmeta-cli.Objective
This PR updates the meta key validation to allow
@in meta keys while preserving the existing key structure rules.This PR also adds test coverage for valid keys containing
@, including real-world stage setup/teardown-style keys, and keeps invalid@placements rejected.References
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.