feat: make YAML merge key limit configurable [1] - #186
Merged
Conversation
This was referenced Jul 17, 2026
y-oksaku
approved these changes
Jul 21, 2026
yakanechi
approved these changes
Jul 21, 2026
minghay
approved these changes
Jul 28, 2026
minghay
approved these changes
Jul 28, 2026
|
🎉 This PR is included in version 12.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Some large pipeline configurations exceed js-yaml's default merge key limit. Disabling the limit entirely is unsafe, so the limit needs to be configurable.
Objective
Allow
parsePipelineYamlto acceptmaxTotalMergeKeysand pass it to js-yaml. Invalid values that could disable the limit are rejected.References
These three PRs are designed to be backward-compatible, so merging them in any order should not cause failures. However, merging them in the numbered order—[1] config-parser, [2] models, and [3] screwdriver—is recommended to ensure the configuration is propagated correctly.
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.