restore mission/goal/event listing in FRED2's campaign editor - #7719
Open
Goober5000 wants to merge 1 commit into
Open
restore mission/goal/event listing in FRED2's campaign editor#7719Goober5000 wants to merge 1 commit into
Goober5000 wants to merge 1 commit into
Conversation
The sexp tree refactor (scp-fs2open#7301) moved the OPF listing logic into a shared model that asks the editor for campaign-aware lists via virtual methods on SexpTreeEditorInterface. QtFRED's campaign editor got the necessary overrides, but FRED2's never did, so its OPF_MISSION_NAME / OPF_GOAL_NAME / OPF_EVENT_NAME dropdowns fell back to the currently loaded mission's data instead of the campaign's. Backport the overrides to FRED2, restoring its pre-refactor behavior (including listing only missions at earlier campaign levels), and hoist QtFRED's loadAndFindCampaignMission helper into missioneditor/common so both editors share one copy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Goober5000
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sexp tree refactor (#7301) moved the OPF listing logic into a shared model that asks the editor for campaign-aware lists via virtual methods on SexpTreeEditorInterface. QtFRED's campaign editor got the necessary overrides, but FRED2's never did, so its OPF_MISSION_NAME / OPF_GOAL_NAME / OPF_EVENT_NAME dropdowns fell back to the currently loaded mission's data instead of the campaign's.
Backport the overrides to FRED2, restoring its pre-refactor behavior (including listing only missions at earlier campaign levels), and hoist QtFRED's loadAndFindCampaignMission helper into missioneditor/common so both editors share one copy.