preserve custom player wing arrival cues - #7716
Draft
Goober5000 wants to merge 1 commit into
Draft
Conversation
Goober5000
added
enhancement
Goober5000
force-pushed
the
enhancement/player_wing_waves
branch
from
August 17, 2026 02:22
94e5990 to
9c1c7dd
Compare
FRED and qtFRED no longer overwrite a hand-edited arrival cue on the wing containing the player start. The cue is editable when the wing has multiple waves (where it governs the arrival of subsequent waves) and read-only otherwise. Waves and threshold are now editable for the single-player player wing, while the arrival delay remains locked; the arrival location is editable in both editors. Both error checkers flag a single-wave player wing with a custom cue as a potential issue, and the engine now warns and aborts the mission load, rather than tripping an Assert, if the player start ship was not created at mission start. Also fix an unguarded read of Ships[Player_start_shipnum] in both editors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Goober5000
force-pushed
the
enhancement/player_wing_waves
branch
from
August 17, 2026 02:23
9c1c7dd to
b774d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FRED and qtFRED no longer overwrite a hand-edited arrival cue on the wing containing the player start. The cue is editable when the wing has multiple waves (where it governs the arrival of subsequent waves) and read-only otherwise. Waves and threshold are now editable for the single-player player wing, while the arrival delay remains locked; the arrival location is editable in both editors.
Both error checkers flag a single-wave player wing with a custom cue as a potential issue, and the engine now warns and aborts the mission load, rather than tripping an Assert, if the player start ship was not created at mission start.
Also fix an unguarded read of Ships[Player_start_shipnum] in both editors.
Fixes #7160. In draft pending testing.