Add AI goals for destroying turrets of a certain type - #7700
Open
Kestrellius wants to merge 4 commits into
Open
Conversation
wookieejedi
added
enhancement
Goober5000
requested changes
Aug 17, 2026
Goober5000
left a comment
Goober5000
left a comment
Contributor
There was a problem hiding this comment.
Partial review for now; still looking through this
|
|
||
| // Goober5000 - before doing anything else, check if this is a disarm goal for an arrived ship... | ||
| if ((status == SHIP_STATUS_ARRIVED) && (aigp->ai_mode == AI_GOAL_DISARM_SHIP || aigp->ai_mode == AI_GOAL_DISARM_SHIP_TACTICAL)) | ||
| if ((status == SHIP_STATUS_ARRIVED) && (aigp->ai_mode == AI_GOAL_DISARM_SHIP || aigp->ai_mode == AI_GOAL_DISARM_SHIP_TACTICAL || aigp->ai_mode == AI_GOAL_DESTROY_TURRET_TYPE_ON_SHIP)) |
Contributor
There was a problem hiding this comment.
I don't think AI_GOAL_DESTROY_TURRET_TYPE_ON_SHIP should be lumped in with standard disarm here. I think it needs its own separate handling, just like the other places.
Contributor
Author
There was a problem hiding this comment.
Hmm. What other behavior are you envisioning? I suppose I could check whether any turret aboard the ship has the specified weapon.
Contributor
Author
|
Good catches, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces two new AI goals,
AI_GOAL_DESTROY_TURRET_TYPEandAI_GOAL_DESTROY_TURRET_TYPE_ON_SHIP, which cause the AI to target turrets carrying a specific class of weapon, either on a targeted ship or on any enemy ship in the mission. From a player-experience perspective, this should help to resolve a certain type of irritating situation that occurs when destroying multiple heavy weapons on an enemy warship is necessary, but wingmen can't effectively help without impractical amounts of micromanagement.At present, these orders are accessible only through SEXPs and scripting, but future plans involve integrating them into the player commands system.