Qtfred & FRED fix object cloning#7460
Open
MjnMixael wants to merge 5 commits into
Open
Conversation
MjnMixael
added
qtfred
MjnMixael
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6191 by creating a shared object duplication file with methods that mirror the parse/save fields and comments in each relevant place to help ensure they don't diverge again in the future. After doing this for ships it seemed prudent to do it for Jump Nodes, Waypoints, and Props as well. All cloneable object types should fully clone now instead of silently dropping field data.
I did sneak in a minor QtFRED feature here where shift-ctrl-drag allows inserting waypoints into a path rather than duplicating them into a new path. The code overhead is minor and related to the work here as I also had to fix ctrl-drag not working in QtFRED in the first place.