unlimited mission titles#7448
Open
Goober5000 wants to merge 1 commit into
Open
Conversation
Goober5000
added
the
enhancement
Goober5000
force-pushed
the
feature/unlimited_title
branch
2 times, most recently
from
c266a00 to
2faac6d
Compare
Member
|
|
Contributor
Author
|
Theoretically, but that wouldn't be a problem, any more than two missions with "Untitled" would be a problem. File names need to be unique, but titles do not. |
Some code refactoring to allow mission titles to be strings of any length. Titles that are too long to actually display (based on string width) will be visibly truncated using `font::force_fit_string`, but the underlying title will not be affected. Multiplayer is still subject to the 31-character length limit, so titles sent over the network will still have characters truncated. Also removes some redundant calls to `gr_get_string_size`, since `font::force_fit_string` returns the fitted string width.
Goober5000
force-pushed
the
feature/unlimited_title
branch
from
2faac6d to
ef73e25
Compare
wookieejedi
approved these changes
May 12, 2026
Member
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Looks good and nice QoL update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some code refactoring to allow mission titles to be strings of any length. Titles that are too long to actually display (based on string width) will be visibly truncated using
font::force_fit_string, but the underlying title will not be affected. Multiplayer is still subject to the 31-character length limit, so titles sent over the network will still have characters truncated.Also removes some redundant calls to
gr_get_string_size, sincefont::force_fit_stringreturns the fitted string width.