Skip to content

board: fix LightsManager init call for Freenove ESP32-S3 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scott-macg merged 1 commit into from
Jul 16, 2026
Merged

board: fix LightsManager init call for Freenove ESP32-S3 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal_filesystem/lib/mpos/board/freenove_esp32s3_display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ def adc_to_voltage(raw_adc):
# ==============================
if __debug__: logger.debug("freenove_esp32s3_display.py: init NeoPixel")
from mpos import LightsManager
LightsManager.init(neopixel_pin=42, num_leds=1)
LightsManager.init(neopixel_pin=42)
LightsManager.set_led_num(1)
Comment on lines +217 to +218

@gemini-code-assist gemini-code-assist Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the new initialization flow, LightsManager.set_led_num(1) initializes the NeoPixel with clear_on_init=False. This means the NeoPixel is no longer cleared (turned off) on boot, which is a regression from the previous behavior where init cleared the LEDs. To ensure the LED is turned off on startup, we should explicitly call clear() and write().

Suggested change
LightsManager.init(neopixel_pin=42)
LightsManager.set_led_num(1)
LightsManager.init(neopixel_pin=42)
LightsManager.set_led_num(1)
LightsManager.clear()
LightsManager.write()


# ==============================
# Step 7: Audio (ES8311 codec + FM8002E amplifier)
Expand Down
Loading