More 5.0 stuff that I should have done on main.#367
Open
scott-griffiths wants to merge 66 commits into
Open
Conversation
* Removing bitarray dependency. * Removing tobitarray() method and other compatibilities. * Removing options.using_rust_core flag. * Removing bitarray tests from CI.
Removing some unneeded methods.
added 29 commits
May 27, 2026 12:45
Adding Reader class that adds a bit position by wrapping either a Bits or BitArray.
…errors and confusion especially for start and end parameters.
Key changes: Added Bits.from_zeros, from_ones, from_bools, from_bytes, from_file, from_joined, from_dtype, and from_string. Added matching BitArray factories returning mutable instances. Added Bits.to_bitarray() and BitArray.to_bits(). Removed fromstring; use from_string. Made Bits(100) / BitArray(100) raise with a from_zeros hint. Removed direct constructor paths for arbitrary bool iterables, BytesIO, file objects, and array.array; tests/docs now use explicit factories. Updated internal uses such as Array(...) storage allocation and display helpers to avoid BitArray(n) / Bits(n).
Bits.to_bytes() / to_file() with tobytes() / tofile() aliases. Array.to_list() / to_bytes() / to_file() / from_file() with old aliases. Reader.read_list() / peek_list() / read_to() / byte_align() with old aliases. Left bytealigned unchanged. Updated README, docs, quick reference, walkthrough notebook, and release notes to prefer the new names. Added tests covering the new spellings and the old compatibility shims.
…in for compatibility.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Documentation | 51 minor |
| ErrorProne | 3 high |
🟢 Metrics 154 complexity · 4 duplication
Metric Results Complexity 154 Duplication 4
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.