feat: display label names on figures - #679
Open
krishna5379chaudhary-eng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds label names to bounding box and polygon figures in the LabelLab labelling interface.
Previously, the label name was associated with the selected label but was not passed to the rendered figure, so the annotation shape did not display its label. This change passes
label_nameto the figure and displays it using a permanent Leaflet tooltip.Fixes #389
Type of change
How Has This Been Tested?
The modified files were checked with ESLint:
Result: 0 errors. Existing Prettier warnings were reported.
Also ran:
No whitespace errors were reported.
The application was started locally, but the local environment became stuck on the authentication page, so the bounding box/polygon UI could not be reached for browser-based verification. No changes were made to the authentication system because it is unrelated to this issue.
Test Configuration:
Screenshots: Not available because the local application could not proceed past authentication.
Checklist: