Move base images to dhi.io - #130
Merged
mathieu-benoit merged 1 commit intoSep 6, 2026
Merged
Conversation
Contributor
Author
|
Hi @mathieu-benoit, This is ready for review. It moves the builder and runtime stages to Two things worth flagging:
Happy to adjust anything, including switching the CI login to the OIDC flow if you'd prefer that. |
Contributor
|
Amazing, @Abhishek9639, thanks! |
Signed-off-by: Abhishek <abhishekup082@gmail.com>
Abhishek9639
force-pushed
the
move-dockerfile-to-dhi
branch
from
September 4, 2026 04:37
1debc17 to
ab5a8cf
Compare
Contributor
Author
|
Hi @mathieu-benoit,
Let me know if anything else is needed! |
mathieu-benoit
self-requested a review
September 4, 2026 10:19
mathieu-benoit
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
Moves the builder and runtime stages to Docker Hardened Images, on the same base image digests
score-composeandscore-k8sare on today:golang:1.26-alpinedhi.io/golang:1.26.5-alpine3.24-devgcr.io/distroless/staticdhi.io/static:20260611-alpine3.24Following score-spec/score-compose#391 and score-spec/score-k8s#250, this also covers the two knock-on effects of the move.
dhi.iois an authenticated registry.github/dependabot.ymlgets thedhiregistry, otherwise Dependabot silently stops bumping the base image digests.dhi.iobefore building the image.score-composeandscore-k8sput on their container jobs.make test, lint andmake test-appstill run, so fork PRs keep meaningful CI.The hardened runtime image runs as a nonroot user
initandgeneratewrite into the mounted working directory, which the container user doesn't own.make test-containernow runs those two commands as the current user.score-composeandscore-k8ssolve the same thing withsudo chown -R 65532:65532in CI.--useris used here instead because this repo drives its container test through the Makefile, which is also run locally, wheresudowould prompt for a password.Needed before CI can go green
DOCKER_HUB_USERNAMEandDOCKER_HUB_TOKENneed to be added as both Actions secrets (for the CI login) and Dependabot secrets (for the registry independabot.yml) these are separate stores, and configuring only one leaves the other silently broken.Testing
make testpasses.docker/login-actionSHA is v4.6.0.score-composecurrently has onmainwith green CI.Notes
score-k8s:--platform=$BUILDPLATFORM, since this repo has no multi-arch build.DOCKER_HUB_ORGandDOCKER_HUB_OIDC_CONNECTION_IDrepo variables, so I kept the username/password login that Dependabot needs regardless.docker build. Flagging in case that changes what you'd like here.