Add missing requirements for eol-watcher#230
Conversation
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
|
Warning Review limit reached
More reviews will be available in 50 minutes and 13 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR consolidates development tooling setup, applies code formatting, updates production dependencies, and migrates environment variable naming. Black and ruff are added as dev dependencies with configuration in pyproject.toml and pre-commit hooks. The code formatting in checker.py and test_checker.py reflects linting standards. Runtime dependencies colorama and atlassian-python-api are added. Environment variables for mail loading switch from ChangesDevelopment Tooling, Code Formatting, and Configuration Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 60.31% 60.49% +0.17%
==========================================
Files 13 13
Lines 1333 1339 +6
==========================================
+ Hits 804 810 +6
Misses 529 529
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@eol-checker/eol_checker/utils.py`:
- Line 98: sclorg_mails is only populated under the "python" key which leads to
KeyError when code later looks up versioned container names (e.g.,
container_name values like python36, python38, python311); update the population
logic that uses get_env_variable("PYTHON_MAILS") so that sclorg_mails contains
entries for the versioned keys (or ensure lookups use a safe fallback), for
example by assigning the parsed list to "python" and also to each versioned key
you expect (python36, python38, python39, python311, python312) or by changing
downstream lookups to use sclorg_mails.get(container_name,
sclorg_mails.get("python", [])); reference symbols: sclorg_mails,
get_env_variable("PYTHON_MAILS"), and container_name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6b2bdfb8-89ca-4bde-a9eb-f25878798185
📒 Files selected for processing (8)
.gitignore.pre-commit-config.yamleol-checker/eol_checker/checker.pyeol-checker/eol_checker/utils.pyeol-checker/tests/test_checker.pypyproject.tomlrequirements-dev.txtrequirements.txt
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit
Chores
.gitignoreto exclude local virtual environment directory.Refactor
*_MAILSvariable names (e.g.,DB_MAILS) instead of*_SMEfor ecosystem-specific settings.