Skip to content

Add missing requirements for eol-watcher#230

Merged
phracek merged 3 commits into
sclorg:masterfrom
phracek:add_missing_dependencies
May 28, 2026
Merged

Add missing requirements for eol-watcher#230
phracek merged 3 commits into
sclorg:masterfrom
phracek:add_missing_dependencies

Conversation

@phracek
Copy link
Copy Markdown
Member

@phracek phracek commented May 28, 2026

Summary by CodeRabbit

  • Chores

    • Updated development dependencies and pre-commit hook configurations with newer versions of code quality tools.
    • Added runtime dependencies to support enhanced output formatting and Jira integration.
    • Updated .gitignore to exclude local virtual environment directory.
  • Refactor

    • Environment configuration now uses *_MAILS variable names (e.g., DB_MAILS) instead of *_SME for ecosystem-specific settings.

Review Change Stack

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Warning

Review limit reached

@phracek, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 13 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c1748573-eeca-42c9-9f57-1758d1605c32

📥 Commits

Reviewing files that changed from the base of the PR and between 2d3478e and c11d0bc.

📒 Files selected for processing (4)
  • .github/workflows/build-and-push.yml
  • Dockerfile.daily-tests
  • Makefile
  • eol-checker/eol_checker/utils.py
📝 Walkthrough

Walkthrough

This PR consolidates development tooling setup, applies code formatting, updates production dependencies, and migrates environment variable naming. Black and ruff are added as dev dependencies with configuration in pyproject.toml and pre-commit hooks. The code formatting in checker.py and test_checker.py reflects linting standards. Runtime dependencies colorama and atlassian-python-api are added. Environment variables for mail loading switch from *_SME to *_MAILS naming across ecosystems.

Changes

Development Tooling, Code Formatting, and Configuration Updates

Layer / File(s) Summary
Linting and formatting toolchain
.gitignore, .pre-commit-config.yaml, pyproject.toml, requirements-dev.txt, eol-checker/eol_checker/checker.py, eol-checker/tests/test_checker.py
Adds .venv to gitignore. Updates black pre-commit hook to official psf/black repository at version 24.10.0 and removes mypy hook. Configures black and ruff in pyproject.toml with line-length: 100. Adds black>=24.0.0 and ruff>=0.8.0 to dev dependencies. Reformats code in checker.py and test_checker.py to align with linting standards (line wrapping, expression condensing, mock setup formatting).
Production dependency additions
requirements.txt
Adds colorama and atlassian-python-api to runtime dependencies.
Environment variable naming migration
eol-checker/eol_checker/utils.py
Migrates load_mails_from_environment to use *_MAILS environment variables instead of *_SME for all tracked ecosystems (mariadb, mysql, postgresql, ruby, python, nodejs, perl, php, redis, varnish, valkey, httpd, nginx).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 The linters dance and formatters play,
Black and ruff now lead the way,
With SME renamed to MAILS so bright,
And dependencies added just right,
The code now gleams in perfect light! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Add missing requirements for eol-watcher' accurately summarizes the main change: adding missing dependencies to requirements files (colorama, atlassian-python-api, black, ruff) and updating configuration files accordingly.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.49%. Comparing base (f4a239e) to head (c11d0bc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   60.31%   60.49%   +0.17%     
==========================================
  Files          13       13              
  Lines        1333     1339       +6     
==========================================
+ Hits          804      810       +6     
  Misses        529      529              
Flag Coverage Δ
daily-tests-unit 44.26% <ø> (ø)
eol-checker-unit 90.09% <100.00%> (+0.18%) ⬆️
ocp-stream-generator-unit 84.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
eol-checker/eol_checker/checker.py 99.40% <100.00%> (ø)
eol-checker/eol_checker/utils.py 93.75% <100.00%> (+0.89%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@eol-checker/eol_checker/utils.py`:
- Line 98: sclorg_mails is only populated under the "python" key which leads to
KeyError when code later looks up versioned container names (e.g.,
container_name values like python36, python38, python311); update the population
logic that uses get_env_variable("PYTHON_MAILS") so that sclorg_mails contains
entries for the versioned keys (or ensure lookups use a safe fallback), for
example by assigning the parsed list to "python" and also to each versioned key
you expect (python36, python38, python39, python311, python312) or by changing
downstream lookups to use sclorg_mails.get(container_name,
sclorg_mails.get("python", [])); reference symbols: sclorg_mails,
get_env_variable("PYTHON_MAILS"), and container_name.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b2bdfb8-89ca-4bde-a9eb-f25878798185

📥 Commits

Reviewing files that changed from the base of the PR and between f4a239e and 2d3478e.

📒 Files selected for processing (8)
  • .gitignore
  • .pre-commit-config.yaml
  • eol-checker/eol_checker/checker.py
  • eol-checker/eol_checker/utils.py
  • eol-checker/tests/test_checker.py
  • pyproject.toml
  • requirements-dev.txt
  • requirements.txt

Comment thread eol-checker/eol_checker/utils.py Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@phracek phracek merged commit c0b1fb9 into sclorg:master May 28, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant