Skip to content

release SOS1/SOS2 constraints after addition #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joao-Dionisio merged 3 commits into from
May 6, 2026
+7 −2
Merged

release SOS1/SOS2 constraints after addition #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
357dda3
release SOS constraints after addition
pfetsch May 5, 2026
a1d1ba5
store python constraint and return it
pfetsch May 5, 2026
9e41c2c
add changelog entry
pfetsch May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Added `getBase()` and `setBase()` methods to `LP` class for getting/setting basis status
- Added `getMemUsed()`, `getMemTotal()`, and `getMemExternEstim()` methods
- Added `isReoptEnabled()` and raising error if not enabled upon calling `reoptSolve()`
- SOS1/SOS2 constraints are now realease after addition similar to the other constraint types
### Fixed
- Removed `Py_INCREF`/`Py_DECREF` on `Model` in `catchEvent`/`dropEvent` that caused memory leak for imbalanced usage
- Used `getIndex()` instead of `ptr()` for sorting nonlinear expression terms to avoid nondeterministic behavior
Expand Down
8 changes: 6 additions & 2 deletions src/pyscipopt/scip.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7151,8 +7151,10 @@ cdef class Model:
PY_SCIP_CALL(SCIPaddVarSOS1(self._scip, scip_cons, wrapper.ptr[i], weights[i]))

PY_SCIP_CALL(SCIPaddCons(self._scip, scip_cons))
pyCons = self._getOrCreateCons(scip_cons)
PY_SCIP_CALL(SCIPreleaseCons(self._scip, &scip_cons))

return self._getOrCreateCons(scip_cons)
return pyCons

def addConsSOS2(self, vars, weights=None, name="",
initial=True, separate=True, enforce=True, check=True,
Expand Down Expand Up @@ -7216,8 +7218,10 @@ cdef class Model:
PY_SCIP_CALL(SCIPaddVarSOS2(self._scip, scip_cons, wrapper.ptr[i], weights[i]))

PY_SCIP_CALL(SCIPaddCons(self._scip, scip_cons))
pyCons = self._getOrCreateCons(scip_cons)
PY_SCIP_CALL(SCIPreleaseCons(self._scip, &scip_cons))

return self._getOrCreateCons(scip_cons)
return pyCons

def addConsAnd(self, vars, resvar, name="",
initial=True, separate=True, enforce=True, check=True,
Expand Down
Loading