Implement pointobservation - #61
Open
finsberg wants to merge 12 commits into
Open
Conversation
Implement pointobservation using fenicsx-ii
finsberg
marked this pull request as ready for review
August 19, 2026 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I this PR we add PointObersevation class which builds the operator$B$ , such that
as well as a new function
point_obersvation_misfitwhich build the following functionalGiven some poinst where you have your obersverations
points, the operatrorBis created aswhere
Vis the relevant finite element space.AI assistance
I used Claude Code (Claude Sonnet 5) to help profile, implement, and iterate on several of these changes. I reviewed, tested, and take responsibility for the final contribution.