Unblock arsenal bumps on 9.3: realign replication tests for CRR ObjectMD refactor#6193
Draft
delthas wants to merge 2 commits into
Draft
Unblock arsenal bumps on 9.3: realign replication tests for CRR ObjectMD refactor#6193delthas wants to merge 2 commits into
delthas wants to merge 2 commits into
Conversation
Pure formatting pass (no logic change) on the test files touched by the arsenal 8.4.7 realignment, so the prettier CI check (which runs on whole files modified by the PR) passes. Isolating the reformat keeps the functional commit reviewable. Issue: CLDSRV-929
Adopt arsenal 8.4.7 on the 9.3 line (was 8.4.4) so it stops being frozen off arsenal patches. The multi-destination CRR refactor (arsenal #2627, in 8.4.7) made ObjectMD.replicationInfo's single-destination fields optional/deprecated: empty defaults changed '' -> undefined, and the top-level dataStoreVersionId is dropped in favor of per-backend values. This is backward-compatible (the API is unchanged and the cloudserver build passes); only test expectations drift. - tests/unit/api/objectReplicationMD.js: realign expected replicationInfo to the 8.4.7 shape (deprecated fields undefined; no top-level dataStoreVersionId). - tests/functional/aws-node-sdk/test/bucket/putBucketReplication.js: remove three cases that asserted the old single-destination restriction (overlapping prefixes across destinations; multiple destination buckets) — these configs are now accepted under multi-destination CRR. Verified locally against 8.4.7: full unit suite green (5097 passing); putBucketReplication functional 58 passing. Issue: CLDSRV-929
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
LGTM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/9.3 #6193 +/- ##
================================================
Coverage 84.63% 84.63%
================================================
Files 206 206
Lines 13356 13356
================================================
Hits 11304 11304
Misses 2052 2052
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Unblocks the
development/9.3line to consume arsenal 8.4.7 (it was pinned to 8.4.4 and would fail CI on any bump to >= 8.4.7). Bumps arsenal to 8.4.7 and realigns the replication tests to the new (backward-compatible)ObjectMD.replicationInfoshape.Why
Arsenal PR scality/Arsenal#2627 ("Support multi-destination CRR", first released in 8.4.7; already consumed by 9.4 via #6172) reworked
ObjectMD.replicationInfo:destination/role/storageClass/storageType/dataStoreVersionId) are now optional/deprecated in favor of per-backend values inbackends[];'' -> undefined, and the top-leveldataStoreVersionIdis dropped.This is backward-compatible — the API surface cloudserver consumes is unchanged and the
buildjob passes. Only test expectations drift.Changes
tests/unit/api/objectReplicationMD.js: realign expectedreplicationInfoto the 8.4.7 shape (deprecated fieldsundefined; no top-leveldataStoreVersionId). Pure expectation update.tests/functional/aws-node-sdk/test/bucket/putBucketReplication.js: remove three cases that asserted the old single-destination restriction (overlapping prefixes across destinations; multiple destination buckets). Under multi-destination CRR these configs are now accepted.Verification (local, against arsenal 8.4.7)
putBucketReplicationfunctional: 58 passing.mpuVersionfunctional: 42 passing (the CImongo-v1-ftInternalErrors did not reproduce in isolation — a cross-test cascade, not a regression).Removing those 3 tests means 9.3 now accepts multi-destination replication configs it has no feature code to honor (multi-dest is implemented only on 9.4: #6172/#6178/#6179). Keeping this draft until the replication owner (maeldonn) confirms accepting-but-not-honoring such configs on 9.3 is acceptable.
Issue: CLDSRV-929