Improvement/CLDSRV-825 drop ceph support by benzekrimaha · Pull Request #6097 · scality/cloudserver

benzekrimaha · 2026-03-09T16:19:11Z

bert-e · 2026-03-09T16:19:23Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

tests/functional/aws-node-sdk/test/object/rangeTest.js

tests/multipleBackend/routes/routeBackbeat.js

tests/functional/aws-node-sdk/test/object/rangeTest.js

tests/multipleBackend/routes/routeBackbeat.js

tests/multipleBackend/multipartUpload.js

tests/multipleBackend/routes/routeBackbeat.js

tests/functional/aws-node-sdk/test/multipleBackend/objectCopy/objectCopy.js

tests/functional/aws-node-sdk/test/multipleBackend/objectCopy/objectCopyAwsVersioning.js

bert-e · 2026-03-09T16:37:59Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

This commit drops Ceph CI artifacts and location config, removes Ceph-specific runtime defaults, and updates reported capability flags and related unit coverage to match supported backends. Issue: CLDSRV-825

claude · 2026-03-09T16:47:33Z

LGTM

Clean removal of all Ceph-related code: Docker files, location config, CI_CEPH env var checks, isCEPH/itSkipCeph/describeSkipIfCeph conditionals, and capability flags. No leftover Ceph references found in JS, JSON, or YAML files. The test-utils exports are consistent after the change.

Review by Claude Code

This commit remove Ceph-specific skip logic and behavior branches from multiple-backend/functional suites, and cleans stale Ceph comments in test files. Issue: CLDSRV-825

Issue: CLDSRV-825

claude · 2026-03-16T07:00:05Z

LGTM

Clean removal of Ceph support across the codebase. The capability flag is correctly hardcoded to false, Config.js CI_CEPH env var checks are properly removed, and previously-always-skipped tests (describeSkipIfNotMultipleOrCeph was set to describe.skip unconditionally) are now correctly gated by describeSkipIfNotMultiple. The rangeTest.js refactoring to return part ETags from uploadParts for CompleteMultipartUpload is correct since Promise.all preserves input order.

Review by Claude Code

…ties fixing tests after re enabling them

tests/multipleBackend/routes/routeBackbeat.js

lib/Config.js

DarkIsDude

I found some CEPH reference in the product doc that we should also clean. The CI is still unstable

lib/utilities/reportHandler.js

francoisferrand · 2026-04-01T19:40:07Z

lib/Config.js

        if (config.capabilities) {
            if (config.capabilities.locationTypes) {
-                this.supportedLocationTypes = new Set(config.capabilities.locationTypes);
+                this.supportedLocationTypes = new Set(


why?
this should not be needed, unless there is an issue in tests.... so the tests should be updated instead: we should not adapt production code to tests, but tests to match how it happens in production

francoisferrand · 2026-04-01T19:46:10Z

tests/multipleBackend/multipartUpload.js

@@ -531,7 +523,7 @@ describe('Multipart Upload API with AWS Backend', function mpuTestSuite() {
                })).then(() => {
                    assert.fail('Expected an error listing parts of aborted MPU');
                }).catch(err => {
-                    const wantedError = isCEPH ? 'NoSuchKey' : 'NoSuchUpload';
+                    const wantedError = 'NoSuchUpload';


variable probably not needed here

francoisferrand · 2026-04-01T19:47:25Z

tests/unit/utils/reportHandler.js

                awsIngestLocation: false,
            });
+            assert.strictEqual(
+                Object.prototype.hasOwnProperty.call(caps, 'locationTypeCephRadosGW'),


useless: redundant with assert.deepStrictEqual above, can never fail...

francoisferrand · 2026-04-01T19:47:35Z

tests/unit/utils/reportHandler.js

                customCapability: 'test-value',
            });
+            assert.strictEqual(
+                Object.prototype.hasOwnProperty.call(caps, 'locationTypeCephRadosGW'),


useless: redundant with assert.deepStrictEqual above, can never fail...

francoisferrand

a few small things, but more importantly it seems to me this cleanup is not complete: this is modifying only the tests, but we keep the code handling specific corner cases for cepth (which may be either/both in cloudserver and arsenal).

this code MUST be cleaned as well, otherwise we just continue maintaining the same code, just with less coverage

bert-e · 2026-04-08T13:05:51Z

Branches have diverged

This pull request's source branch improvement/CLDSRV-825-drop-ceph-support has diverged from
development/9.3 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

Merge origin/development/9.3 into improvement/CLDSRV-825-drop-ceph-support
Rebase improvement/CLDSRV-825-drop-ceph-support onto origin/development/9.3

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

benzekrimaha · 2026-04-08T16:44:35Z

@francoisferrand Thanks for the careful review — I agree with your point that removing tests without removing related code would leave us with untested legacy behavior.
I re-audited this PR specifically with that objective:
I listed CEPH-conditioned test removals (isCEPH / itSkipCeph / describeSkipIfCeph / CEPH-only expected error variants).
I mapped those removed tests to the corresponding runtime paths.
I removed the CEPH-specific runtime handling that was still present.
What was actually CEPH-specific in CloudServer:
=> Capability-key cleanup in reportHandler getCapabilities() (locationTypeCephRadosGW / cephIngestLocation) was the remaining CEPH-specific logic.
This has now been removed, and the matching unit test coverage was removed accordingly.
What remains and why:
The remaining behaviors touched by removed CEPH-conditioned tests are generic S3/MPU API semantics, not CEPH branches. Examples:
Internal MPU metadata NoSuchKey mapped to public NoSuchUpload.
Multipart delete behavior controlled by legacyAwsBehavior.
Standard versioning/object-lock semantics (NoSuchKey / NoSuchVersion / MethodNotAllowed).
These paths are still covered by active non-CEPH tests.
So this is not a tests-only cleanup anymore:
CEPH-specific runtime handling in CloudServer has been removed.
Remaining logic is generic compatibility behavior with active coverage.
If you want, I can also do the same explicit mapping pass on Arsenal in a follow-up to ensure both repos are aligned.

francoisferrand · 2026-04-09T07:36:57Z

lib/utilities/reportHandler.js

-    delete caps.locationTypeCephRadosGW;
-    delete caps.cephIngestLocation;


this was an earlier comment, we need to keep these!
cloudserver will not support ceph anymore, so we don't want to advertise that we still support it

francoisferrand · 2026-04-09T07:40:57Z

Capability-key cleanup in reportHandler getCapabilities() (locationTypeCephRadosGW / cephIngestLocation) was the remaining CEPH-specific logic.

this is not "ceph-specific" logic, this is logic which was introduced earlier on purpose to correctly report that we DO NOT support ceph anymore. So it must be kept.

I can also do the same explicit mapping pass on Arsenal in a follow-up to ensure both repos are aligned.

yes, as discussed on Monday we need to check in Arsenal as well : where the actual specifics of each (data) backend are implemented

benzekrimaha changed the title ~~Improvement/cldsrv 825 drop ceph support~~ Improvement/CLDSRV-825 drop ceph support Mar 9, 2026