Skip to content

configurable ingestion batch size - #2790

Open
SylvainSenechal wants to merge 1 commit into
improvement/BB-685from
improvement/BB-686
Open

configurable ingestion batch size#2790
SylvainSenechal wants to merge 1 commit into
improvement/BB-685from
improvement/BB-686

Conversation

@SylvainSenechal

@SylvainSenechal SylvainSenechal commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.67%. Comparing base (38ef032) to head (7e9cc25).

Files with missing lines Patch % Lines
bin/ingestion.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
extensions/ingestion/IngestionConfigValidator.js 100.00% <ø> (ø)
bin/ingestion.js 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.22% <ø> (ø)
Core Library 81.79% <ø> (+0.56%) ⬆️
Ingestion 70.13% <ø> (ø)
Lifecycle 80.25% <ø> (ø)
Oplog Populator 85.83% <ø> (ø)
Replication 62.02% <ø> (+0.03%) ⬆️
Bucket Scanner 85.76% <ø> (ø)
@@                  Coverage Diff                   @@
##           improvement/BB-685    #2790      +/-   ##
======================================================
+ Coverage               75.43%   75.67%   +0.23%     
======================================================
  Files                     201      201              
  Lines                   13929    13929              
======================================================
+ Hits                    10508    10541      +33     
+ Misses                   3411     3378      -33     
  Partials                   10       10              
Flag Coverage Δ
api:retry 9.06% <0.00%> (ø)
api:routes 8.83% <0.00%> (ø)
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 10.69% <0.00%> (+1.55%) ⬆️
ingestion 12.26% <0.00%> (ø)
lib 8.79% <0.00%> (ø)
lifecycle 19.25% <0.00%> (+<0.01%) ⬆️
notification 1.00% <0.00%> (ø)
oplogPopulator 0.13% <0.00%> (ø)
replication 18.81% <0.00%> (ø)
unit 54.74% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread tests/unit/ingestion/IngestionConfigValidator.spec.js Outdated
Comment thread bin/ingestion.js
function queueBatch(ingestionPopulator, log) {
log.debug('start queueing ingestion batch');
const maxRead = qpConfig.batchMaxRead;
// Extension-level batchMaxRead overrides the shared queuePopulator value.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless 👀 ?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@SylvainSenechal
SylvainSenechal marked this pull request as ready for review August 4, 2026 13:02
@SylvainSenechal
SylvainSenechal requested review from a team, DarkIsDude and delthas August 4, 2026 13:02
Comment thread bin/ingestion.js
function queueBatch(ingestionPopulator, log) {
log.debug('start queueing ingestion batch');
const maxRead = qpConfig.batchMaxRead;
// Extension-level batchMaxRead overrides the shared queuePopulator value.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants