remove unused port-forward PID captures#2446
Conversation
Three `_*_PF_PID=$!` assignments in setup-e2e-env.sh are never referenced after they're set — no wait, kill, or disown. The port-forwards already run in the background fine without capturing the PID. Removes `_KAFKA_PF_PID`, `_KAFKA_AUTH_PF_PID`, `_PROM_PF_PID`. Pure cleanup, no behavior change. Flagged by Maël on Zenko PR #2378 review. Issue: ZENKO-5298
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
SylvainSenechal
left a comment
There was a problem hiding this comment.
there was a problem with it, or is it a pure 3 lines removal cleanup 🤔
Literally a 3 line cleanup 😀 |
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
This pull request does not target the following hotfix branch(es) so they
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZENKO-5298. Goodbye delthas. |
Summary
_*_PF_PID=$!assignments in.github/scripts/end2end/setup-e2e-env.shthat are never read again — nowait,kill, ordisownreferences the captured PIDs anywhere in the file.kubectl port-forward ... &already detaches into the background fine without the capture.Removed
_KAFKA_PF_PID_KAFKA_AUTH_PF_PID_PROM_PF_PIDWhy
Flagged by @maeldonn on PR #2378 review for two new captures we'd added (
_JAEGER_PF_PID,_CLOUDSERVER_INTERNAL_PF_PID); those were dropped in that PR. This one handles the three pre-existing ones.Issue: ZENKO-5298