Skip to content

feat(searchdb): make node_count and node_amount optional #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 2 commits into from
Jun 22, 2026
Merged

feat(searchdb): make node_count and node_amount optional #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2838ae4
feat: update generated APIs
scaleway-bot Jun 19, 2026
acd6bda
Merge branch 'main' into manual_1781867423
remyleone Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions scaleway-async/scaleway_async/searchdb/v1alpha1/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ async def create_deployment(
self,
*,
name: str,
node_amount: int,
node_count: int,
node_type: str,
version: str,
region: Optional[ScwRegion] = None,
project_id: Optional[str] = None,
tags: Optional[list[str]] = None,
node_amount: Optional[int] = None,
node_count: Optional[int] = None,
user_name: Optional[str] = None,
password: Optional[str] = None,
volume: Optional[Volume] = None,
Expand All @@ -82,13 +82,13 @@ async def create_deployment(
"""
Create a new Cloud Essentials for OpenSearch deployment.
:param name: Name of the deployment.
:param node_amount: DEPRECATED: Use node_count instead. Number of nodes.
:param node_count: Number of nodes.
:param node_type: Node type.
:param version: The Opensearch version to use.
:param region: Region to target. If none is passed will use default region from the config.
:param project_id: Project ID in which to create the deployment.
:param tags: Tags.
:param node_amount: DEPRECATED: Use node_count instead. Number of nodes.
:param node_count: Number of nodes.
:param user_name: Username for the deployment user.
:param password: Password for the deployment user.
:param volume: Volume.
Expand All @@ -100,8 +100,6 @@ async def create_deployment(

result = await api.create_deployment(
name="example",
node_amount=1,
node_count=1,
node_type="example",
version="example",
)
Expand All @@ -117,13 +115,13 @@ async def create_deployment(
body=marshal_CreateDeploymentRequest(
CreateDeploymentRequest(
name=name,
node_amount=node_amount,
node_count=node_count,
node_type=node_type,
version=version,
region=region,
project_id=project_id,
tags=tags,
node_amount=node_amount,
node_count=node_count,
user_name=user_name,
password=password,
volume=volume,
Expand Down
12 changes: 6 additions & 6 deletions scaleway-async/scaleway_async/searchdb/v1alpha1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,12 +599,6 @@ def marshal_CreateDeploymentRequest(
if request.name is not None:
output["name"] = request.name

if request.node_amount is not None:
output["node_amount"] = request.node_amount

if request.node_count is not None:
output["node_count"] = request.node_count

if request.node_type is not None:
output["node_type"] = request.node_type

Expand All @@ -619,6 +613,12 @@ def marshal_CreateDeploymentRequest(
if request.tags is not None:
output["tags"] = request.tags

if request.node_amount is not None:
output["node_amount"] = request.node_amount

if request.node_count is not None:
output["node_count"] = request.node_count

if request.user_name is not None:
output["user_name"] = request.user_name

Expand Down
20 changes: 10 additions & 10 deletions scaleway-async/scaleway_async/searchdb/v1alpha1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,16 +353,6 @@ class CreateDeploymentRequest:
Name of the deployment.
"""

node_amount: int
"""
DEPRECATED: Use node_count instead. Number of nodes.
"""

node_count: int
"""
Number of nodes.
"""

node_type: str
"""
Node type.
Expand All @@ -388,6 +378,16 @@ class CreateDeploymentRequest:
Tags.
"""

node_amount: Optional[int] = 0
"""
DEPRECATED: Use node_count instead. Number of nodes.
"""

node_count: Optional[int] = 0
"""
Number of nodes.
"""

user_name: Optional[str] = None
"""
Username for the deployment user.
Expand Down
14 changes: 6 additions & 8 deletions scaleway/scaleway/searchdb/v1alpha1/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ def create_deployment(
self,
*,
name: str,
node_amount: int,
node_count: int,
node_type: str,
version: str,
region: Optional[ScwRegion] = None,
project_id: Optional[str] = None,
tags: Optional[list[str]] = None,
node_amount: Optional[int] = None,
node_count: Optional[int] = None,
user_name: Optional[str] = None,
password: Optional[str] = None,
volume: Optional[Volume] = None,
Expand All @@ -82,13 +82,13 @@ def create_deployment(
"""
Create a new Cloud Essentials for OpenSearch deployment.
:param name: Name of the deployment.
:param node_amount: DEPRECATED: Use node_count instead. Number of nodes.
:param node_count: Number of nodes.
:param node_type: Node type.
:param version: The Opensearch version to use.
:param region: Region to target. If none is passed will use default region from the config.
:param project_id: Project ID in which to create the deployment.
:param tags: Tags.
:param node_amount: DEPRECATED: Use node_count instead. Number of nodes.
:param node_count: Number of nodes.
:param user_name: Username for the deployment user.
:param password: Password for the deployment user.
:param volume: Volume.
Expand All @@ -100,8 +100,6 @@ def create_deployment(

result = api.create_deployment(
name="example",
node_amount=1,
node_count=1,
node_type="example",
version="example",
)
Expand All @@ -117,13 +115,13 @@ def create_deployment(
body=marshal_CreateDeploymentRequest(
CreateDeploymentRequest(
name=name,
node_amount=node_amount,
node_count=node_count,
node_type=node_type,
version=version,
region=region,
project_id=project_id,
tags=tags,
node_amount=node_amount,
node_count=node_count,
user_name=user_name,
password=password,
volume=volume,
Expand Down
12 changes: 6 additions & 6 deletions scaleway/scaleway/searchdb/v1alpha1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,12 +599,6 @@ def marshal_CreateDeploymentRequest(
if request.name is not None:
output["name"] = request.name

if request.node_amount is not None:
output["node_amount"] = request.node_amount

if request.node_count is not None:
output["node_count"] = request.node_count

if request.node_type is not None:
output["node_type"] = request.node_type

Expand All @@ -619,6 +613,12 @@ def marshal_CreateDeploymentRequest(
if request.tags is not None:
output["tags"] = request.tags

if request.node_amount is not None:
output["node_amount"] = request.node_amount

if request.node_count is not None:
output["node_count"] = request.node_count

if request.user_name is not None:
output["user_name"] = request.user_name

Expand Down
20 changes: 10 additions & 10 deletions scaleway/scaleway/searchdb/v1alpha1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,16 +353,6 @@ class CreateDeploymentRequest:
Name of the deployment.
"""

node_amount: int
"""
DEPRECATED: Use node_count instead. Number of nodes.
"""

node_count: int
"""
Number of nodes.
"""

node_type: str
"""
Node type.
Expand All @@ -388,6 +378,16 @@ class CreateDeploymentRequest:
Tags.
"""

node_amount: Optional[int] = 0
"""
DEPRECATED: Use node_count instead. Number of nodes.
"""

node_count: Optional[int] = 0
"""
Number of nodes.
"""

user_name: Optional[str] = None
"""
Username for the deployment user.
Expand Down
Loading