chore: remove docker headers from cassettes - #5960
Draft
remyleone wants to merge 2 commits into
Draft
Conversation
remyleone
force-pushed
the
remove_docker_header
branch
from
August 6, 2026 14:45
3e33d6a to
dbe03a4
Compare
github-actions
Bot
added
the
container
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce Docker-specific data in recorded VCR fixtures used by the container deploy integration tests, by updating the recorder sanitization and refreshing the affected golden/cassette files.
Changes:
- Updated
core/testing_recorder.goto stripX-Registry-Authand to bypass recording/replaying some Docker (moby) traffic. - Refreshed container deploy cassettes (and corresponding golden outputs) with new recorded IDs/endpoints.
- Updated multiple
.goldenfixtures with new “application available at …” URLs.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| core/testing_recorder.go | Adjusts cassette filtering/passthrough behavior to avoid persisting Docker auth/header data. |
| internal/namespaces/container/v1/testdata/test-deploy-simple.golden | Updates expected deploy output URL. |
| internal/namespaces/container/v1/testdata/test-deploy-buildpack.golden | Updates expected deploy output URL. |
| internal/namespaces/container/v1/testdata/test-deploy-build-args.golden | Updates expected deploy output URL. |
| internal/namespaces/container/v1/testdata/test-deploy-app-name-deduced-from-path.golden | Updates expected deploy output URL. |
| internal/namespaces/container/v1/testdata/test-deploy-build-args.cassette.yaml | Refreshes recorded API interactions for the build-args deploy scenario. |
| internal/namespaces/container/v1/testdata/test-deploy-app-name-deduced-from-path.cassette.yaml | Refreshes recorded API interactions for the “app name from path” deploy scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
211
to
+227
| @@ -217,6 +222,10 @@ func getHTTPRecoder(t *testing.T, update bool) (client *http.Client, cleanup fun | |||
| }, nil | |||
| } | |||
|
|
|||
| func ignoreMoby(req *http.Request) bool { | |||
| return strings.HasPrefix(req.UserAgent(), "moby") | |||
| } | |||
Comment on lines
+369
to
+373
| body: '{"id":"969298da-08bd-44d3-b157-ae2338bae826", "name":"cli-t-ctnr-deploy-ba", | ||
| "namespace_id":"fea71aef-9989-43f7-bb8e-640b69a84d08", "description":"", "status":"error", | ||
| "error_message":"Invalid Image architecture. Serverless Containers only support | ||
| the amd64 architecture, but the image was built for the following architectures: | ||
| arm64. Please rebuild the image for the correct architecture using the `--platform=linux/amd64` |
Comment on lines
+369
to
+373
| body: '{"id":"9eb4ff13-38d6-4090-9e9f-2fcd407bad50", "name":"app-cli-t-ctnr-deploy-fp", | ||
| "namespace_id":"839fc623-9dc2-4546-b0dc-255cc72c70d2", "description":"", "status":"error", | ||
| "error_message":"Invalid Image architecture. Serverless Containers only support | ||
| the amd64 architecture, but the image was built for the following architectures: | ||
| arm64. Please rebuild the image for the correct architecture using the `--platform=linux/amd64` |
remyleone
marked this pull request as draft
August 7, 2026 09:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: