-
Notifications
You must be signed in to change notification settings - Fork 49
Mc/golden agent tuneagent #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michael-chou359
wants to merge
7
commits into
main
Choose a base branch
from
mc/golden-agent-tuneagent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
aa2eb57
update task params in db; send temporal signal to workflow
michael-chou359 9d68be2
Merge branch 'main' of github.com:scaleapi/scale-agentex into mc/gold…
michael-chou359 5687970
Merge branch 'main' of github.com:scaleapi/scale-agentex into mc/gold…
michael-chou359 2ee665f
update task
michael-chou359 157abbe
Merge branch 'main' of github.com:scaleapi/scale-agentex into mc/gold…
michael-chou359 5dc4a24
remove signal
michael-chou359 4369c55
comments
michael-chou359 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge_task_paramsskips thetask_updatedstream eventupdate_taskalways publishes atask_updatedevent to the task event stream after writing to the DB.merge_task_paramsonly callstask_repository.merge_paramsand returns, with no equivalent stream publish. When a caller patches onlymerge_params(notask_metadata), theif task_metadata is not Nonebranch in the use case is skipped, soupdate_taskis never reached and no event is ever emitted. Any consumer watching the stream — including the Temporal worker the PR description says must receive a signal — will not be notified of the config change.Prompt To Fix With AI