Skip to content

fix(events): collapse unauthorized-agent list to 404 #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asherfink wants to merge 1 commit into from
Closed

fix(events): collapse unauthorized-agent list to 404 #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions agentex/tests/integration/api/events/test_events_authz_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ async def test_list_events_authorized_returns_200(
"src.domain.services.authorization_service.AuthorizationService.is_enabled",
return_value=True,
)
async def test_list_events_unauthorized_agent_returns_403(
async def test_list_events_unauthorized_agent_returns_404(
self,
is_enabled_authorization_mock,
is_enabled_mock,
Expand All @@ -257,12 +257,13 @@ async def test_list_events_unauthorized_agent_returns_403(
test_agent,
test_task,
):
"""Direct-resource denials surface as 403 (convention from #249/#255)."""
with patch(
"src.utils.http_request_handler.HttpRequestHandler.post_with_error_handling",
side_effect=_mock_post_factory(deny_agent_ids={test_agent.id}),
):
response = await isolated_client.get(
f"/events?task_id={test_task.id}&agent_id={test_agent.id}"
)
assert response.status_code == 403
# Agent denial collapses to 404 so the filter can't reveal cross-tenant
# agent existence.
assert response.status_code == 404
Loading