chore: promote staging c23ff77 to production - #534
Merged
Merged
Conversation
The exemption for this repo's SDK automation App matched its bot by login, agentex-sdk-sync[bot]. A GitHub App bot's login follows the App's name, so when the App was renamed its bot became stainless-sync[bot] and the entry silently stopped matching: release pull requests went back to failing "Validate PR base branch" and drawing the "retarget to next" comment. The stale entry was also a small hole. The rename released the old slug, so anyone could register an App under it and that App's bot would have inherited the exemption. Match on the bot user's numeric ID instead, held once in a workflow-level SDK_AUTOMATION_BOT_ID and read by both checks. A user ID never changes and is never reused, so a future rename cannot break this and a new App reusing the name gets nothing. The old login is removed rather than kept alongside. The other exemptions stay login-based: stainless-app, release-please[bot], github-actions[bot] and dependabot[bot] are not ours to rename. Exercised both run blocks under bash -e against every author case: the renamed bot is exempt from both checks; a different App on the freed name is not; dependabot and human pull requests behave as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ci(lint-pr): exempt the SDK automation App by bot user ID, not login
aringuyen3
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promote from the staging trunk, opened by stlc-promote.yml.
Approve this pull request - do not click Merge. Squash and rebase both rewrite SHAs, which forks the production trunk away from staging and blocks all codegen until someone reconciles them by hand. Merge commits are disabled on this repo.
Once CI is green here and this has one approval, re-run
stlc-promote.ymlin the config repo. It fast-forwardsmainonto these exact commits, GitHub closes this pull request as merged, and the trunks stay byte-identical.The PR appears safe to merge. No broken check or new bypass was found.
What we checked:
SDK_AUTOMATION_BOT_ID. The old login is no longer in either list.Summary
The PR workflow now recognizes the repository’s SDK automation by its stable GitHub user ID instead of only its changeable bot login. That automation can skip title checks and target
mainwithout being blocked by the branch check.Reviews (1) · Last reviewed commit: "Merge pull request #8 from scaleapi/ci/l..."