Repository navigation
fix(env_state): changelog triggers skip a service's internal tables - #140
Closed
earakely-scale wants to merge 2 commits into
Closed
earakely-scale wants to merge 2 commits into
earakely-scale wants to merge 2 commits into
Conversation
_install_changelog_triggers put a row trigger on every table in the schema except _changelog itself. A service's internal tables, named with the same leading underscore, hold no domain rows: the file-bytes table a server keeps next to its rows would log whole blobs into changed_fields on every upload. Skip every underscore-prefixed table, as _changelog already was. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…(Postgres) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
|
Closing: the file store in synthetic-pipelines #1440 ships without a framework-side trigger exclusion; the changelog trigger on the servers' internal file table is accepted as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_install_changelog_triggersput a row trigger on every table in a service's schema except_changelogitself. A service's internal tables carry the same leading underscore and hold no domain rows. The first such table is the file-bytes table a server now keeps next to its rows, and a row trigger there would copy whole blobs intochanged_fieldson every upload. Skip every underscore-prefixed table, the way_changelogalready was.Testing
Unit test on the rendered SQL. The companion synthetic-servers change was exercised end to end in dev with this installer in place: writes to the servers'
_filestables left the changelog empty.🤖 Generated with Claude Code

Confidence Score: 5/5
The PR appears safe to merge; no new actionable issues were found.Summary
The PR makes
_install_changelog_triggersskip underscore-prefixed internal tables.Reviews (2) · Last reviewed commit: "test: an underscore-prefixed service tab..." · Reviewed by Greptile