Skip to content

fix(env_state): changelog triggers skip a service's internal tables - #140

Closed
earakely-scale wants to merge 2 commits into
mainfrom
fix/changelog-triggers-skip-internal-tables
Closed

earakely-scale wants to merge 2 commits into
mainfrom
fix/changelog-triggers-skip-internal-tables

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

_install_changelog_triggers put a row trigger on every table in a service's schema except _changelog itself. A service's internal tables carry the same leading underscore and hold no domain rows. The first such table is the file-bytes table a server now keeps next to its rows, and a row trigger there would copy whole blobs into changed_fields on every upload. Skip every underscore-prefixed table, the way _changelog already was.

Testing

Unit test on the rendered SQL. The companion synthetic-servers change was exercised end to end in dev with this installer in place: writes to the servers' _files tables left the changelog empty.

🤖 Generated with Claude Code

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no new actionable issues were found.

Summary

The PR makes _install_changelog_triggers skip underscore-prefixed internal tables.

  • Changelog triggers skip all underscore-prefixed service tables.

Reviews (2) · Last reviewed commit: "test: an underscore-prefixed service tab..." · Reviewed by Greptile

_install_changelog_triggers put a row trigger on every table in the
schema except _changelog itself. A service's internal tables, named with
the same leading underscore, hold no domain rows: the file-bytes table a
server keeps next to its rows would log whole blobs into changed_fields
on every upload. Skip every underscore-prefixed table, as _changelog
already was.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner October 9, 2026 07:32
Comment thread tst/unit/providers/env_state/test_env_state_provider.py
…(Postgres)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@earakely-scale

Copy link
Copy Markdown
Collaborator Author

Closing: the file store in synthetic-pipelines #1440 ships without a framework-side trigger exclusion; the changelog trigger on the servers' internal file table is accepted as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant