Fix: Integrate offline validation for SBase unit assignments - #322
Open
dyrpsf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve TODO: Integrate offline validation for SBase unit assignments
Description
This PR resolves the pending TODO in
AbstractNamedSBaseWithUnit.javaby shifting unit assignment validation to utilize the JSBML offline validation framework.Previously, programmatic assignment of an invalid unit triggered a hard
IllegalArgumentException, which disrupted model building. This update ensures that invalid unit assignments now gracefully register anSBMLErrorwithin the associatedSBMLDocument's error log (trackingSBMLErrorCodes.CORE_10311syntax requirements), maintaining execution flow while strictly enforcing SBML specifications.Architectural Changes
setUnits(String)to check for a validSBMLDocumentcontext and append anSBMLErrorupon invalid unit assignment.IllegalArgumentExceptionfallback for isolated nodes lacking a document context.TestAbstractNamedSBaseWithUnitsusing Maven targeted testing.cc: @draeger