Skip to content

⚡ [Performance] Fix double initialization of Date in dossier-compiler #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
savvides wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ [Performance] Fix double initialization of Date in dossier-compiler #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension/shared/dossier-compiler.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ function compileSingleAuditToMarkdown(item) {
const title = item.title || 'Course Material';
const pageType = item.pageType || 'Web Page';
const url = item.url || '';
const timestamp = item.timestamp ? new Date(item.timestamp).toLocaleString() : new Date().toLocaleString();
const timestamp = (item.timestamp ? new Date(item.timestamp) : new Date()).toLocaleString();

let md = `# idstack Instructional Design Audit: ${title}\n\n`;
md += `> **Audited Component:** ${pageType} \n`;
Expand Down
2 changes: 1 addition & 1 deletion extension/shared/dossier-compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export function compileSingleAuditToMarkdown(item) {
const title = item.title || 'Course Material';
const pageType = item.pageType || 'Web Page';
const url = item.url || '';
const timestamp = item.timestamp ? new Date(item.timestamp).toLocaleString() : new Date().toLocaleString();
const timestamp = (item.timestamp ? new Date(item.timestamp) : new Date()).toLocaleString();

let md = `# idstack Instructional Design Audit: ${title}\n\n`;
md += `> **Audited Component:** ${pageType} \n`;
Expand Down
Loading