Fix registry SSL certificate path defaults#3232
Open
Aoiujz wants to merge 1 commit intosameersbn:masterfrom
Open
Fix registry SSL certificate path defaults#3232Aoiujz wants to merge 1 commit intosameersbn:masterfrom
Aoiujz wants to merge 1 commit intosameersbn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GITLAB_REGISTRY_KEY_PATH is used for the authentication key pair between GitLab and the registry. It should not also become the implicit source for the nginx TLS certificate path used to proxy the registry externally.
The previous fallback chain mixed these two concerns and could cause the registry proxy to pick up the internal auth key path when SSL_REGISTRY_* was not configured. This change makes the runtime behavior match the documented defaults and keeps the internal auth certificate path separate from the external nginx TLS certificate path.
Testing