Conversation
…rresponding settings UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features related to action handling, settings migration, and notification behavior in the app. The biggest changes are the introduction of a robust serialization/deserialization system for actions, a central action registry, and enhancements to button remapping and notification customization. Additionally, new actions have been added and legacy ones removed, and a new setting for location-based full-screen alarms is now available.
Action Model and Registry Improvements:
ActionGsonAdapter, a shared Gson serializer/deserializer for theActionsealed interface, enabling robust storage and retrieval of action objects in preferences and repositories.ActionRegistry, providing a central, categorized list of available actions for use in automation and button remapping, with support for Android-version-specific actions.Button Remap and Settings Migration:
SettingsRepositoryto migrate legacy string-based button remap actions to the newActionobject format, and added methods for storing and retrieving these actions as JSON. This ensures backwards compatibility and future extensibility. [1] [2]InputEventListenerServiceto use the newgetRemapActionmethod, ensuring button remap logic now works with the new serialized action objects instead of plain strings. [1] [2]Action Model Updates:
CycleSoundModes,ToggleMute,ToggleVibrate, and a configurableSetVolumeaction with support for different audio channels. Removed legacy notification actions (ShowNotification,RemoveNotification) to clean up the action set. [1] [2]Settings and Notification Enhancements:
KEY_LOCATION_REACHED_FULL_SCREEN_ALARM_ENABLED) and corresponding getter/setter to control whether location-reached notifications should trigger a full-screen alarm. The notification channel is now selected based on this setting inLocationReachedService. [1] [2] [3] [4]Other:
DebuggingSettingsActivityin the Android manifest, likely for internal or developer use.