Complete Arabic translation (values-ar) - #815
Merged
sameerasw merged 6 commits intoAug 21, 2026
Merged
Conversation
This pull request introduces a new "Custom Settings" action for DIY automations, allowing users to modify Android system settings (System, Secure, Global) as part of automation workflows. It also improves icon handling for status bar icons, updates permission registration for new features, and adds a utility for recording and diffing settings changes. Additionally, some UI code is refactored for robustness and clarity. **DIY Automations: Custom Settings Action** - Adds a new `CustomSettings` action to the `Action` sealed interface, enabling automations to modify arbitrary Android settings tables (`SYSTEM`, `SECURE`, `GLOBAL`). This includes data classes for settings entries and table selection, and dynamically determines required permissions. - Implements execution logic for `CustomSettings` actions in `CombinedActionExecutor`, attempting to write settings directly and falling back to shell commands if necessary. - Integrates the new action into the automation editor UI, including configuration sheet support and validation. [[1]](diffhunk://#diff-a92131255b03d0107adaea9f58451f043fb58eaf3315ef7089091e969ce56328R269) [[2]](diffhunk://#diff-a92131255b03d0107adaea9f58451f043fb58eaf3315ef7089091e969ce56328R300) [[3]](diffhunk://#diff-a92131255b03d0107adaea9f58451f043fb58eaf3315ef7089091e969ce56328R916) [[4]](diffhunk://#diff-a92131255b03d0107adaea9f58451f043fb58eaf3315ef7089091e969ce56328R1003) [[5]](diffhunk://#diff-a92131255b03d0107adaea9f58451f043fb58eaf3315ef7089091e969ce56328R1287-R1307) - Registers required permissions (`WRITE_SECURE_SETTINGS`, `WRITE_SETTINGS`) for the DIY tab in the permission registry. - Adds a utility class `SettingsRecorder` for snapshotting and diffing Android settings, supporting automation creation based on settings changes. **Status Bar Icon Improvements** - Assigns appropriate drawable resources to several status bar icons (`network_speed`, `glove_mode`, `frame_rate`, `no_sim`) for better visual representation. [[1]](diffhunk://#diff-4ebb52d94300165fea2ca61198a8853d0208c9721065e9776b396d77bb9ae1deL286-R286) [[2]](diffhunk://#diff-4ebb52d94300165fea2ca61198a8853d0208c9721065e9776b396d77bb9ae1deL315-R329) - Refines icon validation in `FeatureCard` to ensure only valid drawable resources are used, with fallbacks for invalid icons. **UI and Codebase Cleanups** - Removes unused animation and Instagram graphic code from `SetupFeatures` for a cleaner user experience. [[1]](diffhunk://#diff-745253453359a8bd398912155bd3e957eef0666756dc31d103c59bf449c503feL1050-L1057) [[2]](diffhunk://#diff-745253453359a8bd398912155bd3e957eef0666756dc31d103c59bf449c503feL1093-L1107) [[3]](diffhunk://#diff-745253453359a8bd398912155bd3e957eef0666756dc31d103c59bf449c503feL1145-L1146) - Updates imports to support new features and code organization. [[1]](diffhunk://#diff-671a778dae0f695de989db0c5d0c1b8dde6f695edd884421f12b230bf37924e6R19-R26) [[2]](diffhunk://#diff-a92131255b03d0107adaea9f58451f043fb58eaf3315ef7089091e969ce56328R99) [[3]](diffhunk://#diff-745253453359a8bd398912155bd3e957eef0666756dc31d103c59bf449c503feL19-L28) These changes collectively enhance the flexibility of automations, improve UI consistency, and lay the groundwork for settings-based automation triggers.
Removed the star history section from the README.
sameerasw
approved these changes
Aug 21, 2026
sameerasw
left a comment
sameerasw
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contributions <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the Arabic (values-ar) translation of the Essentials app.
What's included
%1$s/%1$d/%dplaceholders match the English originalsxmllint; no duplicate keys, no leftover English stringsVerification
1814/1814keys present (0 missing, 0 extra, 0 duplicates vsvalues/strings.xml)