fix(deltaproxy): log sub-proxy init failures at ERROR level instead of INFO [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #70074
Open
waterWang wants to merge 1 commit into
Conversation
…f INFO When a sub-proxy fails during sequential initialization, the exception is caught and logged at INFO level. With the default log_level: warning this means a failure that permanently disables a minion produces zero visible log output — the sub-proxy is simply missing. Fix: log both the per-proxy failure and the summary at ERROR level, matching the existing parallel startup branch behavior. Refs: saltstack#70072
twangboy
requested changes
Aug 18, 2026
twangboy
left a comment
twangboy
left a comment
Contributor
There was a problem hiding this comment.
Please create this against the 3008.x branch. This also needs a changelog and a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #70072
When a deltaproxy control minion initializes its sub-proxies sequentially (the default), an exception during a sub-proxy's initialization is caught and logged at INFO level. With the default
log_level: warning, a failure that permanently disables a minion produces zero visible log output — the sub-proxy silently disappears.The parallel startup path handles this correctly (logs at ERROR + re-raises). This PR brings the sequential path in line:
log.info→log.errorlog.info→log.errorProblem Details
From the issue: after upgrading a production master from 3007.14 to 3008.2, all 21 sub-proxies failed to initialize (netmiko_px proxy module removed from core in 3008). The service showed
active (running), logs contained nothing, and the fleet was silently unmanaged for four days.What does this PR do NOT change?
No behavior change — only the log level of existing failure messages, matching the parallel-startup branch.
Testing
log.infocalls insalt/metaproxy/deltaproxy.pypost_master_init(sequential branch) are nowlog.error.