Index barstools.created_at#19
Merged
Merged
Conversation
Pruning (WHERE created_at <= ?) and recent-first browsing queries were scanning the table, which grows by design. Adds the index to the create stub for new installs plus an upgrade migration guarded with hasIndex so it is a no-op where the index already exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of change
Second of three follow-ups from the review pass behind #17 (feature / schema / accuracy fixes).
The
barstoolstable grows by design, and its two most common access patterns both filter or sort oncreated_at: model pruning (WHERE created_at <= ?) and recent-first browsing. Neither had an index, so both scan the table once it gets large.create_barstools_tablestub:created_atnow indexed for new installsadd_created_at_index_to_barstools_tableupgrade migration for existing installs, guarded withhasIndexso it no-ops if the index already exists (e.g. fresh installs that publish and run both migrations)Existing users publish and run migrations to pick it up; skipping it is safe — everything works without the index, just slower at scale.
Testing
New test running the upgrade migration and asserting the index exists. Full suite: 43 passed (173 assertions), PHPStan level 8 clean, Pint clean.