Add excluded_response_headers config for redacting response headers#18
Merged
Conversation
Response headers were stored unredacted, including Set-Cookie. The new config mirrors the request-side exclusions: named headers are matched case-insensitively and stored as REDACTED, and '*' or a connector or request class redacts every response header value. Set-Cookie is redacted by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of change
First of three follow-ups from the review pass behind #17 (split for clean history: feature / schema / accuracy fixes).
Response headers were stored completely unredacted — including
Set-Cookie, so session cookies could land in thebarstoolstable. This addsexcluded_response_headers, mirroring the request-side exclusions:REDACTED'*'or a connector/request class redacts every response header value (keys kept, valuesREDACTED)Set-Cookieis redacted by default — a behaviour change for existing installs, but a safe direction (data that was previously leaking into logs is now masked)README updated with a matching section.
Testing
Two new tests: default Set-Cookie redaction alongside untouched headers, and a dataset covering
'*'/connector-class/request-class wildcard redaction. Full suite: 42 passed (172 assertions), PHPStan level 8 clean, Pint clean.