Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,34 @@
<!-- codex-os-managed -->
## What

Brief description of the changes.
-

## Why

Why is this change needed?
-

## How
-

## Testing
- Commands run:
- Results:

## Performance impact
- Bundle delta:
- Build time delta:
- Lighthouse delta:
- API latency delta:
- DB query delta:

## Risk / Notes
-

How were the changes implemented? Any design decisions worth noting?
## Screenshots (UI only)
-

## Checklist
## Lockfile rationale (if lockfile changed)
-

- [ ] Tests pass
- [ ] No new warnings
- [ ] Documentation updated (if applicable)
## Baseline governance (if .perf-baselines changed)
- `perf-baseline-update` label applied:
- Reviewer signoff:
- Rollback note:
12 changes: 6 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<!-- codex-os-managed -->
## What
-
-

## Why
-
-

## How
-
-

## Testing
- Commands run:
Expand All @@ -20,13 +20,13 @@
- DB query delta:

## Risk / Notes
-
-

## Screenshots (UI only)
-
-

## Lockfile rationale (if lockfile changed)
-
-

## Baseline governance (if .perf-baselines changed)
- `perf-baseline-update` label applied:
Expand Down
27 changes: 9 additions & 18 deletions AGENTS.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,14 @@
## Definition of Done: Tests + Docs (Blocking)
# AGENTS.md

<!-- comm-contract:start -->

## Communication Contract (Global)
## Communication Contract

- Follow `/Users/d/.codex/policies/communication/BigPictureReportingV1.md` for all user-facing updates.
- Use exact section labels from `BigPictureReportingV1.md` for default status/progress updates.
- Keep default updates beginner-friendly, big-picture, and low-noise.
- Keep technical details in internal artifacts unless explicitly requested by the user.
- Honor toggles literally: `simple mode`, `show receipts`, `tech mode`, `debug mode`.
- Inherit global Codex communication and reporting rules from `/Users/d/.codex/AGENTS.override.md` and `/Users/d/.codex/policies/communication/BigPictureReportingV1.md`.
- Repo-specific instructions below add project constraints only; do not restate global voice or status-reporting rules here.
<!-- comm-contract:end -->
- Any production code change must include meaningful test updates in the same PR.
- Meaningful tests must include at least:
- one primary behavior assertion
- two non-happy-path assertions (edge, boundary, invalid input, or failure mode)
- Trivial assertions are forbidden (`expect(true).toBe(true)`, snapshot-only without semantic assertions, render-only smoke tests without behavior checks).
- Mock only external boundaries (network, clock, randomness, third-party SDKs). Do not mock the unit under test.
- UI changes must cover state matrix: loading, empty, error, success, disabled, focus-visible.
- API/command surface changes must update generated contract artifacts and request/response examples.
- Architecture-impacting changes must include an ADR in `/docs/adr/`.
- Required checks are blocking when `fail` or `not-run`: lint, typecheck, tests, coverage, diff coverage, docs check.
- Reviewer -> fixer -> reviewer loop is required before merge.

## Inherited Operating Rules

- Inherit global git, review/fix, testing, docs, UI, skill-use, and reporting gates from `/Users/d/.codex/AGENTS.md` and active session instructions.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep inherited agent rules repo-local

When this repo is used outside the author's workstation, this absolute /Users/d/.codex/AGENTS.md reference is not available, so the explicit blocking test/docs/reviewer-loop requirements that were deleted above no longer reach Codex agents. I checked this workspace and the referenced /Users/d/.codex/... files are absent, which means a normal checkout loses the repo's Definition of Done instead of inheriting it; either keep those requirements in this file or reference a repo-tracked path.

Useful? React with 👍 / 👎.

- Add repo-specific constraints here only when this project has instructions that differ from global Codex defaults.
Loading