Skip to content

Re-orient entity collision box per sub-level and substep #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minerguy341 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Re-orient entity collision box per sub-level and substep #1349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .../src/main/java/dev/ryanhcode/sable/sublevel/entity_collision/SubLevelEntityCollision.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,16 @@ public static CollisionInfo collide(final Entity entity, final Vec3 collisionMot
lastPose.lerp(logicalPose, (double) (i - 1) / substeps, lastSubLevelPose);
lastPose.lerp(logicalPose, (double) (i) / substeps, subLevelPose);

// Re-orient the entity's collision box to THIS sub-level's pose at THIS substep.
// The computation before the loop reads subLevelPose before it has been set for the
// current iteration, so the box was oriented to the previous substep's pose — or to
// a different sub-level entirely — making entities catch on walls and doorframes of
// rotated sub-levels.
if (customEntityOrientation == null) {
sink.entityBoxOrientation.identity().rotateY(getHitBoxYaw(subLevelPose));
entityBoundsOBB.setOrientation(sink.entityBoxOrientation);
}

rotatedContextBounds.set(fullContextBounds);
if (customEntityOrientation != null) {
entityBoundsOBB.vertices(sink.a);
Expand Down