Skip to content

docs: clear pre-existing docs-check failures - #110

Merged
overtrue merged 1 commit into
mainfrom
docs-ci-cleanup
Jul 16, 2026
Merged

docs: clear pre-existing docs-check failures#110
overtrue merged 1 commit into
mainfrom
docs-ci-cleanup

Conversation

@overtrue

Copy link
Copy Markdown
Collaborator

Summary

Clears every finding the docs:check GitHub Action reports on main, so the workflow goes green. Each was pre-existing and unrelated to any single feature PR.

Code fences without a language (13) — added a language to each: http for S3 request lines (PUT /{bucketName} HTTP/1.1, …), bash for the docker compose command, text for command output, URLs, and the directory tree.

Banned example values (2)

  • developer/mc.md — endpoint 12.34.56.78192.168.1.100 with <your-access-key> / <your-secret-key> placeholders
  • developer/mcp.md — region cn-east-1us-east-1

Orphan pages (2) — deleted two vestigial concept index pages that duplicated the sidebar: concepts/index.md (a hand-maintained TOC) and concepts/principle/index.md (which listed unlinked placeholder bullets — "Stripes / Data Scanner / Data Self-healing / Stripes", the "画饼目录" flagged in the review). The real child, erasure-coding, is linked directly in the sidebar and is untouched.

Broken .md links (3) — the three ./docker/index.md reports came from the earlier VitePress→FumaPress rename (docker/index.md.mdx). FumaPress resolves links by URL, not on-disk extension, so a .md link to a page that now ships as .mdx renders fine. Updated scripts/docs-check.mjs to accept a .md link when only the sibling .mdx exists (and vice versa) rather than rewriting the documented .md link convention.

Result

docs-check: OK
PASS  Orphan pages
PASS  Broken relative .md links
PASS  Code fences without a language
PASS  Banned strings
PASS  Referenced images larger than 300 KB

npm run build ✓ (295 pages). Independent of #109 — no overlapping files.

Make `npm run docs:check` pass cleanly:

- Add a language to 13 unlabelled code fences (http for S3 request
  lines, bash for commands, text for output/URLs/trees)
- Replace banned example values: mc.md endpoint 12.34.56.78 -> 192.168.1.100
  with placeholder keys; mcp.md region cn-east-1 -> us-east-1
- Delete two vestigial concept index pages (concepts/index.md and
  concepts/principle/index.md) that duplicated the sidebar and, in the
  case of principle/index, listed unlinked placeholder bullets
- docs-check: resolve a .md link when only the sibling .mdx exists (and
  vice versa), matching how FumaPress maps links by URL — fixes the
  three docker/index.mdx link reports

docs-check now passes; build OK (295 pages).
Copilot AI review requested due to automatic review settings July 16, 2026 05:59
@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-rustfs-com Ready Ready Preview, Comment Jul 16, 2026 5:59am

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
docs-rustfs-com 0414be9 Commit Preview URL

Branch Preview URL
Jul 16 2026, 06:00 AM

@overtrue
overtrue merged commit be1deb1 into main Jul 16, 2026
4 checks passed
@overtrue
overtrue deleted the docs-ci-cleanup branch July 16, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants